x402 Payload now returns the root delegator, instead of the leaf delegator#251
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 37e110f. Configure here.
a823df6 to
3607751
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📝 Description
The
x402DelegationProviderwas incorrectly returning the leaf delegator, instead of the root delegator.This PR fixes that.
🔄 What Changed?
List the specific changes made:
🚀 Why?
Explain the motivation behind these changes:
🧪 How to Test?
Describe how to test these changes:
List any breaking changes:
📋 Checklist
Check off completed items:
🔗 Related Issues
Link to related issues:
Closes #
Related to #
📚 Additional Notes
Any additional information, concerns, or context:
Note
Medium Risk
Changes the meaning of
delegatoron an experimental payment API; correct for delegation chains but may break consumers that assumed the leaf delegator.Overview
The experimental
createx402DelegationProviderpayment payload now exposes the root delegator for the delegation chain instead of the leaf delegator from the newly signed open delegation.resolveDelegationCreationContextcomputesrootDelegatoras the delegator on the last entry inexistingDelegations(fromparentPermissionContext), orfromwhen there is no parent chain, and the provider returns that address indelegator. Tests and the changelog entry for the experimental provider are updated accordingly.Integrators that relied on the previous (incorrect) leaf
delegatorvalue will see a behavior change when redeeming or displaying x402 payloads with a parent permission context.Reviewed by Cursor Bugbot for commit 3607751. Bugbot is set up for automated code reviews on this repo. Configure here.